Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add client config option + registry auth e2e tests #844

Merged
merged 8 commits into from
Jun 7, 2021

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented May 24, 2021

  • Adds a --registry-config-dir flag in VM create, image import and kernel
    import subcommands.
  • Adds field registryConfigDir in ignite configuration.
  • Update v1alpha4 API and add custom conversion function for v1alpha3.
  • Adds setup-private-registry.sh script to setup a local docker registry
    with self-signed cert and basic auth.
  • Adds test util to delete image from ignite and the runtime content
    store.
  • Adds e2e tests for image import with configurations set via flag and
    ignite configuration.
  • Update go version in semaphore to 1.16.3 to use os.WriteFile().

Follow-up of #833

TODO:

  • Update ignite configuration docs to add examples of registry configuration option.
  • Add an option to toggle insecure skip verify in TLS client of containerd remote registry resolver.
  • Maybe an option to support plain http in remote registry resolver.

- Adds a --client-config-dir flag in VM create, image import and kernel
import subcommands.
- Adds field clientConfigDir in ignite configuration.
- Update v1alpha4 API and add custom conversion function for v1alpha3.
- Adds setup-private-registry.sh script to setup a local docker registry
with self-signed cert and basic auth.
- Adds test util to delete image from ignite and the runtime content
store.
- Adds e2e tests for image import with configurations set via flag and
ignite configuration.
- Enable docker registry setup only in semaphore CI for e2e tests.
- Update go version in semaphore to 1.16.3 to use os.WriteFile().
@darkowlzz darkowlzz added area/testing Issues related to improving testing area/UX Let's make Ignite's UX great! kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 24, 2021
…nd TLS-ignore-verify /w tests :)

Co-Authored-By: Sunny <darkowlzz@protonmail.com>
@stealthybox
Copy link
Contributor

stealthybox commented May 25, 2021

It's good to see the test runtime for this is actually quite good on Semaphore.

36s - Registry Setup
26s - TestPullFromAuthRegistry

1m02s

This mainly checks if the remote resolver enforces the usage of insecure
registries when the registry server address is http.
TestPullFromAuthRegistry executes the script to set up the registries
at the beginning and stop the registries at the end of the test.

Remove registry setup from semaphore
When the registry set up script is execited from the go e2e tests, it
modified the user's default docker config permissions. Use a test config
directory to avoid modifying the default docker configuration file.
@stealthybox stealthybox merged commit 33fdc51 into weaveworks:main Jun 7, 2021
@stealthybox
Copy link
Contributor

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Issues related to improving testing area/UX Let's make Ignite's UX great! kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants